Changeset 362

Timestamp:

05/19/08 22:16:04 (7 months ago)

Author:

johnbywater

Message:

Defending against non-integer encoded record id values.

Files:

• trunk/src/dm/db.py (modified) (2 diffs)

trunk/src/dm/db.py

@@ -183 +183 @@
-        def get(self, className, id):
-            "Retreive record of domain object."
+            try:
+                id = int(id)
+            except:
+                msg = "Couldn't cast id to int for %s: %s" % (className, id)
+                raise Exception, msg
-            recordClass = self.getRecordClass(className)
-            return recordClass.get(id)  # todo: pass transaction
@@ -1134 +1139 @@
-                if self.meta.attributeDbNames[name].isDomainObjectRef:
-                    name += '_id'
+            if name == 'id':
+                value = int(value)
-            # todo: expand for all database systems
-            sqlSafeValue = sqlrepr(value, 'postgres')